fix(model): allow backwards compat as per MCP spec #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
T-test
This was referenced Aug 7, 2025
alexhancock
previously approved these changes
Aug 7, 2025
Contributor
Author
|
@alexhancock PTAL again - not sure about the comment lint check though |
michaelneale
force-pushed
the
micn/structured_content_fix
branch
from
b83bc36 to
7f33cdf
Compare
michaelneale
changed the title
crepererum
reviewed
Aug 7, 2025
| assert_eq!(result.is_error, Some(true)); | ||
| } | ||
|
|
||
| #[tokio::test] |
There was a problem hiding this comment.
maybe keep the test and check that it it doesn't error at the end?
crepererum
reviewed
Aug 7, 2025
Collaborator
|
@crepererum I addressed the feedback in #359 - not pushing to this one since it's @michaelneale's fork and I won't have access |
Collaborator
|
Merged #359 which has these changes! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small fix for issue: #355
MCP servers (especially in python) will likely fail with 0.4.0 with an error like "Error: Unexpected response type"
this is due to the validation
content and structured_content are mutually exclusive, but this is a bit strict.How Has This Been Tested?
Tested with goose and a python based MCP server - it worked with < 0.4.0 and failed with 0.4.0.
I then tested this patch with the goose agent and exactly the same server it works.
Breaking Changes
None
Types of changes
Checklist